2024/09/15 23:57 11/17 Github Desktop
Batocera.linux - Wiki - https://wiki.batocera.org/
A pull request can only be done via the web page, there is no way to do this from Github
Desktop itself. This is by design.
When you're ready to submit your changes, click Ready for review.
I messed up and need to change something
Don't fret, you can still make changes to your pull request as long as it hasn't been merged yet (a
draft pull request cannot be merged). Ensure that you're on the branch that you made the pull
request from, make your additional changes, and commit them again. The changes will be reflected in
the pull request immediately.
If you've ended up making many commits, it is polite to “squash” them into one commit as it is easier
to keep track of things that way. After all, if you're a dev and find that a component of Batocera has
broken due to a change made months ago, sifting through ten or twenty commits titled “fixed
mistake” is the commit history with little context as to what they were for isn't the most pleasant
experience.
To squash multiple commits into one:
Ensure you're still on the branch you have made the pull request on1.
Click on History near the top left of the window2.
Select the commits you wish to squash (either by holding [Ctrl] and clicking each one or3.
holding [Shift] and selecting the first commit you made)
Right-click and select Squash <#> commits4.
Create a new title and description that includes all your changes5.